Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve deprecation warnings when building Cython examples #1935

Merged
merged 9 commits into from
Dec 17, 2024
Merged

Resolve deprecation warnings when building Cython examples #1935

merged 9 commits into from
Dec 17, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk commented Dec 13, 2024 •
edited
Loading

This PR adds conda list of the build environment to help understand the origin of compiler warnings in CI which are not reproducible locally.

Edit:

This PR resolves the issue by upgrading building system for Cython examples to use scikit-build.
CMake ensures that header files from the correct location are used.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_325 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@coveralls
Copy link
Collaborator

coveralls commented Dec 13, 2024 •
edited
Loading

Coverage Status

coverage: 87.659%. remained the same
when pulling ac978f1 on triage-example-warnings
into 5352dd5 on master.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_326 ran successfully.
Passed: 895
Failed: 1
Skipped: 118

@oleksandr-pavlyk
Copy link
Collaborator Author

The warnings in test_examples_linux step come from

In file included from blackscholes/blackscholes.cpp:1325:
In file included from /usr/share/miniconda/envs/examples/include/python3.11/../sycl/sycl.hpp:25:
In file included from /usr/share/miniconda/envs/examples/include/python3.11/../sycl/detail/core.hpp:21:
In file included from /usr/share/miniconda/envs/examples/include/python3.11/../sycl/accessor.hpp:11:

The folder $CONDA_PREFIX/include/python.311/../sycl does not exist for me locally, since my DPC++ comes from system-wide installation.

@oleksandr-pavlyk
Copy link
Collaborator Author

The immediate reason is that intel-sycl-rt package seems to include SYCL headers:

$ grep -r "sycl.hpp" $CONDA_PREFIX/conda-meta/
/localdisk/work/opavlyk/mamba/envs/test_examples/conda-meta/intel-sycl-rt-2025.0.4-intel_1519.json:    "include/sycl/CL/sycl.hpp",

Compiler finds these header files instead of those packages in the compiler itself in build_env environment.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_345 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_346 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_340 ran successfully.
Passed: 893
Failed: 3
Skipped: 118

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review December 14, 2024 18:51
@oleksandr-pavlyk
Copy link
Collaborator Author

I've changed build system for Cython examples over to scikit-build, and the warnings are now all gone.

@oleksandr-pavlyk oleksandr-pavlyk changed the title Add conda list of build environment Resolve deprecation warnings when building Cython examples Dec 14, 2024
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_341 ran successfully.
Passed: 895
Failed: 1
Skipped: 118

ndgrigorian
ndgrigorian approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnings are gone so this LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit d9b9e0c into master Dec 17, 2024
48 of 51 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the triage-example-warnings branch December 17, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian